luizotavio32 commented on code in PR #36934:
URL: https://github.com/apache/superset/pull/36934#discussion_r2670472489
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx:
##########
@@ -717,6 +725,10 @@ const Chart = props => {
/>
</ChartWrapper>
+ {!isLoading && queriedDttm && (
Review Comment:
Resolved on commit
[77fc5dd](https://github.com/apache/superset/pull/36934/commits/77fc5dd3ce3565d7a831eb3854b0595856e94c6c)
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx:
##########
@@ -310,10 +312,16 @@ const Chart = props => {
return DEFAULT_HEADER_HEIGHT;
}, [headerRef]);
+ const queriedDttm = queriesResponse?.[0]?.queried_dttm ?? null;
+
const getChartHeight = useCallback(() => {
const headerHeight = getHeaderHeight();
- return Math.max(height - headerHeight - descriptionHeight, 20);
- }, [getHeaderHeight, height, descriptionHeight]);
+ const queriedLabelHeight = queriedDttm ? QUERIED_LABEL_HEIGHT : 0;
Review Comment:
Resolved on commit
[77fc5dd](https://github.com/apache/superset/pull/36934/commits/77fc5dd3ce3565d7a831eb3854b0595856e94c6c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
