sadpandajoe opened a new issue, #36964: URL: https://github.com/apache/superset/issues/36964
## Summary Add a Playwright E2E test to verify that the time range pre-filter option is hidden when a dataset has no temporal columns. ## Background This test scenario was originally implemented as a Jest/RTL unit test in `FiltersConfigModal.test.tsx` but was skipped in September 2021 (PR #16906) due to flakiness. After 11 fix attempts, it was determined that this scenario cannot be reliably tested at the unit test level due to: 1. The modal architecture requires complex Redux + API mock coordination 2. `showTimeRangePicker` depends on `loadedDatasets` populated by async API fetch during mount 3. Timing issues between state updates and component rendering create race conditions The underlying logic is now covered by unit tests for `shouldShowTimeRangePicker` and `hasTemporalColumns` in `utils.test.ts`. ## Test Scenario 1. Create/edit a filter with a dataset that has **no temporal columns** (only String, Numeric, Boolean types) 2. Open the filter configuration modal 3. Navigate to the Settings tab 4. Enable the pre-filter checkbox 5. **Verify**: The time range pre-filter option should NOT be shown ## Acceptance Criteria - [ ] Playwright test covers the scenario described above - [ ] Test uses a dataset fixture with `column_types` containing no `GenericDataType.Temporal` (value 2) - [ ] Test is stable and not flaky ## Related - PR #36012 - Removed the skipped Jest test - Original feature: PR #15225 (June 2021) - Original skip: PR #16906 (September 2021) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
