geido commented on code in PR #36708:
URL: https://github.com/apache/superset/pull/36708#discussion_r2672083634
##########
superset-frontend/src/components/Chart/chartAction.js:
##########
@@ -590,9 +591,33 @@ export function refreshChart(chartKey, force, dashboardId)
{
) {
return;
}
- dispatch(
+
+ // Fetch the latest chart definition from the database to ensure we use
+ // the most recent configuration (e.g., if the chart was modified in
another tab)
+ let formDataToUse = chart.latestQueryFormData;
+ try {
+ const queryParams = rison.encode({
+ columns: ['params'],
+ });
+ const { json } = await SupersetClient.get({
Review Comment:
I find it weird that we need to re-request the form data here. The function
seems to expect the data to be fresh already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
