michael-s-molina commented on code in PR #36929: URL: https://github.com/apache/superset/pull/36929#discussion_r2672166440
########## superset-frontend/packages/superset-core/src/spec/utils/logging.test.ts: ########## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +beforeEach(() => { + jest.resetModules(); + jest.resetAllMocks(); +}); + +it('should pipe to `console` methods', () => { Review Comment: ```suggestion test('should pipe to `console` methods', () => { ``` ########## superset-frontend/packages/superset-core/src/ui/translation/Translator.ts: ########## @@ -17,7 +17,7 @@ * under the License. */ import UntypedJed from 'jed'; -import logging from '../utils/logging'; +import logging from '../../utils/logging'; Review Comment: The README file is still referencing `@superset-ui/core`. ########## superset-frontend/packages/superset-core/src/spec/utils/logging.test.ts: ########## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +beforeEach(() => { + jest.resetModules(); + jest.resetAllMocks(); +}); + +it('should pipe to `console` methods', () => { + const { logging } = require('@apache-superset/core'); + + jest.spyOn(logging, 'debug').mockImplementation(); + jest.spyOn(logging, 'log').mockImplementation(); + jest.spyOn(logging, 'info').mockImplementation(); + expect(() => { + logging.debug(); + logging.log(); + logging.info(); + }).not.toThrow(); + + jest.spyOn(logging, 'warn').mockImplementation(() => { + throw new Error('warn'); + }); + expect(() => logging.warn()).toThrow('warn'); + + jest.spyOn(logging, 'error').mockImplementation(() => { + throw new Error('error'); + }); + expect(() => logging.error()).toThrow('error'); + + jest.spyOn(logging, 'trace').mockImplementation(() => { + throw new Error('Trace:'); + }); + expect(() => logging.trace()).toThrow('Trace:'); +}); + +it('should use noop functions when console unavailable', () => { Review Comment: ```suggestion test('should use noop functions when console unavailable', () => { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
