massucattoj opened a new pull request, #36983: URL: https://github.com/apache/superset/pull/36983
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Harden date range parsing in get_since_until by bounding whitespace quantifiers in time_range_lookup regex patterns to prevent potential ReDoS (Regular Expression Denial of Service) attacks. **Changes:** - Replace unbounded `\s+` with `\s{1,5}` (1-5 whitespace characters) - Replace unbounded `\s*` with `\s{0,5}` (0-5 whitespace characters) This ensures the regex engine fails quickly on malformed inputs with excessive whitespace, rather than potentially hanging while trying many backtracking combinations. All existing valid date expressions continue to work as before. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - Backend regex change with no UI impact. ### TESTING INSTRUCTIONS 1. Run the unit tests: ` pytest tests/unit_tests/utils/date_parser_tests.py -v ` 2. Verify all tests pass, including the new `test_time_range_bounded_whitespace_regex` parametrized test. 3. Test in UI: Go to Chart Explorer → Time Range → Advanced → Enter expressions like last 7 days, start of next month. OBS: Should work as before. This was a performance and security improvement. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
