bito-code-review[bot] commented on code in PR #36983:
URL: https://github.com/apache/superset/pull/36983#discussion_r2672914980
##########
tests/unit_tests/utils/date_parser_tests.py:
##########
@@ -611,3 +611,48 @@ def test_date_range_migration() -> None:
field = "10 years ago"
assert not re.search(DateRangeMigration.x_dateunit, field)
+
+
+# Tests for bounded whitespace regex patterns in time_range_lookup
[email protected](
+ "time_range,should_parse",
Review Comment:
<!-- Bito Reply -->
Yes, pytest.mark.parametrize accepts the first argument (argnames) in two
formats: a string with comma-separated names (e.g., "time_range, should_parse")
or a tuple/list of strings (e.g., ("time_range", "should_parse")). Both are
valid and equivalent.
**tests/unit_tests/utils/date_parser_tests.py**
```
@pytest.mark.parametrize(
("time_range", "should_parse"),
[
("last 7 days : ", True),
("this week : ", True),
# ... more cases
],
)
def test_time_range_parsing(time_range: str, should_parse: bool) -> None:
result = get_since_until(time_range)
assert (result[0] is not None) == should_parse
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
