codeant-ai-for-open-source[bot] commented on PR #36012:
URL: https://github.com/apache/superset/pull/36012#issuecomment-3726323378
## **Sequence Diagram**
The PR moves time-range visibility logic out of FiltersConfigForm into a
pure utility (shouldShowTimeRangePicker) and adds unit tests for that util and
related functions; the diagram shows the main decision flow and the added test
coverage hitting the utils.
```mermaid
sequenceDiagram
participant FiltersConfigForm as UI
participant Utils as shouldShowTimeRangePicker
participant Utils2 as hasTemporalColumns
participant Dataset as Dataset (column_types)
participant Tests as Unit Tests
UI->>Utils: shouldShowTimeRangePicker(currentDataset)
Utils->>Utils2: if dataset defined -> hasTemporalColumns(dataset)
Utils2->>Dataset: read column_types
Dataset-->>Utils2: column_types
Utils2-->>Utils: returns boolean (has temporal?)
Utils-->>UI: returns boolean (showTimeRangePicker)
UI->>UI: render TimeRangePicker if true
Tests->>Utils: call shouldShowTimeRangePicker / hasTemporalColumns /
other utils
Utils-->>Tests: return expected values (covered by new unit tests)
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
