richardfogaca commented on code in PR #35683:
URL: https://github.com/apache/superset/pull/35683#discussion_r2674324258
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/buildQuery.ts:
##########
@@ -481,6 +543,54 @@ const buildQuery: BuildQuery<TableChartFormData> = (
}
}
+ // Create totals query AFTER all filters (including AG Grid filters) are
applied
Review Comment:
it seems there are way too many comments, do we need them all? can we maybe
reduce them and keep the essential ones to improve readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
