ramiroaquinoromero opened a new pull request, #37012: URL: https://github.com/apache/superset/pull/37012
### SUMMARY Fixed two issues with native filter management on dashboards: 1. Deleted filters now disappear immediately after saving instead of persisting until page refresh 2. Filters without assigned charts now show "not in scope" indicator, even on dashboards without tabs **Changes:** - Updated reducer to replace old filters with server response instead of merging, ensuring deleted filters are removed - Enhanced scope logic to mark filters as out-of-scope when chartsInScope is explicitly empty - UI now displays out-of-scope filters collapsible on all dashboards, not just those with tabs ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before:** User deletes a filter, clicks save, and the filter remains visible until page refresh https://github.com/user-attachments/assets/d1babdde-4b74-47f1-948f-e097abc979a5 **After:** User deletes a filter, clicks save, and the filter immediately disappears from the dashboard https://github.com/user-attachments/assets/c79e95e4-82ab-40d5-94cd-30c4eee1b6fc ### TESTING INSTRUCTIONS **Test filter deletion:** - Go to a dashboard and edit native filters - Add a filter and save - Delete that filter and save - Verify the filter disappears immediately without page refresh ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
