ramiroaquinoromero commented on code in PR #37012: URL: https://github.com/apache/superset/pull/37012#discussion_r2680884860
########## superset-frontend/src/dashboard/components/nativeFilters/state.ts: ########## Review Comment: @msyavuz @kgabryje Good morning. I updated the solution. That is the main reason for this implementation **Problem:** When filters were deleted on the backend, the reducer wasn't removing them from the state. The old logic merged backend filters with existing state filters, causing deleted filters to persist in the UI. **Solution:** Refactored handleFilterChangesComplete to create a new filters object containing only the filters returned from the backend response. When you get a chance please review it. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
