rebenitez1802 opened a new pull request, #37059:
URL: https://github.com/apache/superset/pull/37059
### SUMMARY
Fixes #34865 where APP_NAME configuration stopped working for browser
window/tab titles after the Ant Design v5 theme migration in Superset 6.0.
**Changes:**
- Added `brandAppName` theme token for application name in window titles
- Implemented 3-tier fallback: `brandAppName` → `APP_NAME` config →
`"Superset"`
- Updated frontend title cleanup to use theme token instead of hardcoded
"Superset"
- Applied fallback to bootstrap payload so React components receive correct
value
**Backward compatibility:** Existing `APP_NAME` configurations continue to
work automatically via fallback mechanism.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:** Window title always shows "Superset" regardless of `APP_NAME`
config
**After:** Window title shows configured `APP_NAME` value (e.g., "My Test
Analytics Platform")
### TESTING INSTRUCTIONS
1. Set `APP_NAME = "Custom App Name"` in `superset_config.py`
2. Start Superset and navigate to login page
3. Verify browser tab shows "Custom App Name" instead of "Superset"
4. Navigate to a dashboard/chart, verify title changes to dashboard name
5. Navigate away, verify title returns to "Custom App Name"
**Or test with new theme system:**
```python
THEME_DEFAULT = {
"token": {
"brandAppName": "My Custom Analytics",
}
}
```
### ADDITIONAL INFORMATION
- [x] Has associated issue: #34865
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
