amaannawab923 commented on code in PR #36416:
URL: https://github.com/apache/superset/pull/36416#discussion_r2683269485
##########
superset/datasets/schemas.py:
##########
@@ -166,6 +166,7 @@ class DatasetPutSchema(Schema):
schema = fields.String(allow_none=True, validate=Length(0, 255))
description = fields.String(allow_none=True)
main_dttm_col = fields.String(allow_none=True)
+ currency_code_column = fields.String(allow_none=True, validate=Length(0,
250))
normalize_columns = fields.Boolean(allow_none=True, dump_default=False)
Review Comment:
The ImportV1DataSetSchema must also include this column otherwise importing
to a new environment will suffer from a failure , Please check for Import
Export Scenario ,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
