Abhishekmishra2808 opened a new pull request, #37065: URL: https://github.com/apache/superset/pull/37065
Fixes #37056 Native filters scoped to inactive tabs or sub-tabs are now completely hidden instead of being shown in the "Filters out of scope" section. This ensures consistent UX between top-level tabs and nested sub-tabs: - When a filter is out of scope for the active tab/sub-tab, it is fully hidden - Behavior is now consistent for both top-level and nested tab structures Changes: - Modified `useSelectFiltersInScope` to skip adding out-of-scope tab-scoped filters to the `filtersOutOfScope` array - Updated unit test expectations to verify filters are completely hidden when out of scope <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR fixes inconsistent native filter scoping behavior when dashboards use tabs with sub-tabs. Previously, filters scoped to inactive sub-tabs were still rendered under the "Filters out of scope" section, while the same filters were fully hidden for top-level tabs. The updated logic ensures filters that are out of scope for the active tab or sub-tab are completely hidden, providing a consistent and predictable user experience across all tab levels. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS 1. Create a dashboard with multiple tabs and nested sub-tabs 2. Add a native filter scoped only to one sub-tab 3. Switch to another sub-tab where the filter is out of scope 4. Verify the filter is completely hidden and does not appear under "Filters out of scope" 5. Confirm behavior is consistent for both top-level tabs and nested sub-tabs ### ADDITIONAL INFORMATION - [x] Has associated issue: #37056 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in SIP-59) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
