Facyla opened a new pull request, #37105: URL: https://github.com/apache/superset/pull/37105
fix(CountryMap plugin): fix: issue #36026 Tooltip not displayed on bottom edge of the map ### SUMMARY The tooltip was hidden because it was displayed on a fixed position on right bottom of the hovered area. With the map div not showing overflowing elements, it got hidden when hovering on zones on lower parts of the map. This implementation adds a custom class that is added to hoverable zones on the lower third part of the screen, and the alternate positionning is done with a CSS rule based on that additional class that indicates where the alternate positionning shuld be used. Also considered: - using a fixed tooltip zone (on top left): rejected because it seemed better to have the information next to the hovered eement - more complex dynamic positionning: seemed like too much complexity for a basic feature like tooltips ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before : (tooltip hidden) <img width="166" height="97" alt="image" src="https://github.com/user-attachments/assets/3cdba164-b3cc-4ff5-9b05-2a09a580cd27"; /> After : (tooltip visible) <img width="166" height="97" alt="image" src="https://github.com/user-attachments/assets/9681a301-c145-4fdf-9dd7-63508017e345"; /> ### TESTING INSTRUCTIONS 1. Display a CountryMap visualisation 2. Hover on a zone located at the very bottom of the map: the tooltip should display and be entirely visible (while it was partially or fully hidden before) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/36026 - [ ] Required feature flags: - [x] Changes UI: minor fix - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
