alexandrusoare commented on code in PR #37072:
URL: https://github.com/apache/superset/pull/37072#discussion_r2689970463
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts:
##########
@@ -474,6 +472,15 @@ const transformProps = (
theme,
} = chartProps;
+ // Merge extra_form_data (dashboard filter overrides) into formData
+ // This ensures dashboard-level settings (like time_compare) override
chart-level settings
+ // From PRs #33947 and #34014
+ const formData = merge(
+ {},
+ originalFormData,
+ originalFormData.extra_form_data,
+ );
Review Comment:
My concern regarding this is that we are going to have the data duplicated,
once at the top level of the object and once again in the nested object
`extra_form_data`
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -497,7 +497,7 @@ test('deletes a filter including dependencies', async () =>
{
}),
),
);
-});
+}, 30000);
Review Comment:
Why do we need this timeout now and we didn't need it before? And from the
looks of it this PR doesn't address at all the FiltersConfigModal, is it
something that I am missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
