aminghadersohi opened a new pull request, #37142: URL: https://github.com/apache/superset/pull/37142
## Summary Two fixes for MCP chart tools discovered during Claude Desktop testing: 1. **Big Number charts fallback query fix**: Charts of type `big_number` and `big_number_total` use `metric` (singular) in form_data, not `metrics` (plural). The fallback query construction in `get_chart_data` now handles this correctly, preventing "Empty query?" errors when retrieving data from these chart types. 2. **Semantic warnings now non-blocking**: Runtime semantic warnings (format compatibility, cardinality hints, chart type suggestions) were incorrectly blocking chart generation. These are now logged as informational messages but no longer fail validation. They are optimization hints, not hard errors. ## Test plan - [ ] Test `get_chart_data` tool with a `big_number` chart that has no saved query_context - [ ] Test `generate_chart` with table config using aggregates (previously blocked by semantic warnings) - [ ] Verify semantic warnings are logged but chart generation succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
