alexandrusoare commented on code in PR #37163:
URL: https://github.com/apache/superset/pull/37163#discussion_r2693674828
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -794,7 +795,17 @@ export const ControlPanelsContainer = (props:
ControlPanelsContainerProps) => {
]);
const showCustomizeTab = customizeSections.length > 0;
- const showMatrixifyTab = isFeatureEnabled(FeatureFlag.Matrixify);
+ // Table charts don't support matrixify feature
+ const MATRIXIFY_INCOMPATIBLE_CHARTS = new Set([
+ VizType.Table,
+ VizType.TableAgGrid,
+ VizType.PivotTable,
+ VizType.TimeTable,
+ VizType.TimePivot,
+ ]);
Review Comment:
For future implementations, if we need this set in some place else we should
move this set at some point but for now LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
