Aitema-gmbh opened a new pull request, #37167:
URL: https://github.com/apache/superset/pull/37167
### SUMMARY
This PR addresses several critical accessibility (a11y) issues identified in
a recent WCAG 2.1 Level A audit. The changes focus on structure, navigation,
and state communication for screen reader users.
Specific improvements included in this PR:
1. **Semantic Structure (WCAG 1.3.1):**
- Updated chart titles in `SliceHeader` to use semantic `<h2>` tags
instead of generic divs. This allows screen reader users to navigate the
dashboard structure by headings.
2. **Bypass Blocks (WCAG 2.4.1):**
- Implemented a **Skip to Content** link (hidden visually until focused)
that allows keyboard users to bypass the main navigation menu and jump directly
to the dashboard content.
3. **Labels & Instructions (WCAG 3.3.2):**
- Added a tooltip to the **disabled 'Apply' button** in the Filter Bar.
Previously, the button was simply disabled with no feedback. Now, hovering or
focusing reveals: *"Select filter values to apply"*. This explains *why* the
action is unavailable.
4. **Language of Page (WCAG 3.1.1):**
- Added `lang="en"` to the `<html>` tag in the base template. This
ensures screen readers use the correct pronunciation rules.
5. **Focus Visibility (WCAG 2.4.7):**
- Enhanced global focus styles to ensure interactive elements have a
clear, visible focus indicator.
### BEFORE/AFTER SCREENSHOTS
*Will be provided in comments.*
### TESTING INSTRUCTIONS
1. Open any dashboard.
2. **Tab Navigation:** Press Tab immediately after load. The "Skip to main
content" link should appear at the top left.
3. **Screen Reader:** Inspect Chart headers; they should be announced as
"Heading Level 2".
4. **Filters:** Open the Filter Bar without selecting values. Hover over
the disabled "Apply" button to see the explanatory tooltip.
### ADDITIONAL INFORMATION
- [x] Has associated issue: N/A (Audit findings)
- [x] Changes UI
- [ ] Includes DB Migration
cc @geido @rusackas - We are working on improving a11y across the board and
would appreciate your feedback on these initial fixes aligned with the AntD 5
migration spirit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
