bito-code-review[bot] commented on code in PR #37186: URL: https://github.com/apache/superset/pull/37186#discussion_r2696484775
########## superset/mcp_service/chart/schemas.py: ########## @@ -21,7 +21,6 @@ from __future__ import annotations -import html import re Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Security: XSS via HTML injection</b></div> <div id="fix"> Removing html.escape from sanitization methods allows HTML injection in chart names, labels, and fields, creating XSS vulnerabilities when these values are displayed in HTML contexts. The tag-blocking approach is insufficient, as it misses vectors like <img onerror>. Revert to escaping HTML characters for security. </div> </div> <small><i>Code Review Run #eff4b2</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
