reynoldmorel commented on code in PR #37210:
URL: https://github.com/apache/superset/pull/37210#discussion_r2698414162
##########
superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.test.tsx:
##########
@@ -403,6 +403,7 @@ test('Render tab content with no children, editMode: true,
canEdit: true', () =>
},
},
});
+
expect(screen.queryByTestId('emptystate-drop-indicator')).toBeInTheDocument();
Review Comment:
Is it possible to simulate dropping a dummy html node? like text for example
?
##########
superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.jsx:
##########
@@ -222,6 +216,46 @@ const Tab = props => {
const shouldDropToChild = useCallback(item => item.type !== TAB_TYPE, []);
+ const renderDropableEmptyState = dropProps => {
Review Comment:
Where this is being used?
Probably it is duplicated code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
