Aitema-gmbh commented on PR #37211: URL: https://github.com/apache/superset/pull/37211#issuecomment-3761368172
/resolve ## ✅ All Bito Review Issues Have Been Addressed The review comments reference the original commit `dfcf5ea`, but all issues have been fixed in subsequent commits: ### Fixed in commit `8a1e747`: **1. SkipLink tabindex persistence** - The `tabindex="-1"` is now intentionally kept after focus to maintain keyboard focusability **2. ActionButtons isClearAllEnabled logic** - Now correctly checks BOTH `dataMaskSelected` (pending) AND `dataMaskApplied` (applied) filter values ### Fixed in commit `9ae31b6`: **3. Typo "ore" → "or"** - Corrected to `'One or more annotation layers failed loading.'` --- All fixes verified against current branch state. Ready for human review! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
