bito-code-review[bot] commented on code in PR #37185:
URL: https://github.com/apache/superset/pull/37185#discussion_r2709047269
##########
superset/mcp_service/chart/tool/get_chart_preview.py:
##########
@@ -114,7 +117,7 @@ def generate(self) -> URLPreview | ChartError:
error=f"Could not generate screenshot for chart
{self.chart.id}",
error_type="ScreenshotError",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Narrow exception handling risks uncaught errors</b></div>
<div id="fix">
The except clause only catches (ValueError, KeyError, AttributeError), but
screenshot.get_screenshot can raise TimeoutException, WebDriverException, and
other exceptions from WebDriver operations, which would now propagate unhandled
instead of returning a ChartError.
</div>
</div>
<small><i>Code Review Run #104773</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
