bito-code-review[bot] commented on code in PR #37221: URL: https://github.com/apache/superset/pull/37221#discussion_r2713897045
########## superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/controlPanel.test.ts: ########## @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import type { + ControlPanelSectionConfig, + ControlSetRow, + ControlSetItem, +} from '@superset-ui/chart-controls'; +import controlPanel from './controlPanel'; + +test('controlPanel should have Map section', () => { + const mapSection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Map', + ); + + expect(mapSection).toBeDefined(); + expect(mapSection?.expanded).toBe(true); +}); + +test('controlPanel should have Query section', () => { + const querySection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Query', + ); + + expect(querySection).toBeDefined(); + expect(querySection?.expanded).toBe(true); +}); + +test('controlPanel Map section should include viewport control', () => { + const mapSection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Map', + ); + + // viewport is imported from Shared_DeckGL and included in controlSetRows + expect(mapSection?.controlSetRows).toBeDefined(); + expect(mapSection?.controlSetRows.length).toBeGreaterThan(0); +}); Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Test logic mismatch</b></div> <div id="fix"> The test title indicates it should check for the viewport control's inclusion, but the code only verifies controlSetRows exists and has length >0. This could pass even if viewport is missing, failing to catch regressions. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion // viewport is imported from Shared_DeckGL and included in controlSetRows const viewportRow = mapSection?.controlSetRows.find((row: ControlSetRow) => row.some( (control: ControlSetItem) => control && typeof control === 'object' && 'name' in control && control.name === 'viewport', ), ); const viewportControl = viewportRow?.find( (control: ControlSetItem) => control && typeof control === 'object' && 'name' in control && control.name === 'viewport', ) as any; expect(viewportControl).toBeDefined(); }); ```` </div> </details> </div> <small><i>Code Review Run #acb56e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/controlPanel.test.ts: ########## @@ -0,0 +1,351 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import type { + ControlPanelSectionConfig, + ControlSetRow, + ControlSetItem, +} from '@superset-ui/chart-controls'; +import controlPanel from './controlPanel'; + +test('controlPanel should have Map section', () => { + const mapSection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Map', + ); + + expect(mapSection).toBeDefined(); + expect(mapSection?.expanded).toBe(true); +}); + +test('controlPanel should have Query section', () => { + const querySection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Query', + ); + + expect(querySection).toBeDefined(); + expect(querySection?.expanded).toBe(true); +}); + +test('controlPanel Map section should include viewport control', () => { + const mapSection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Map', + ); + + // viewport is imported from Shared_DeckGL and included in controlSetRows + expect(mapSection?.controlSetRows).toBeDefined(); + expect(mapSection?.controlSetRows.length).toBeGreaterThan(0); +}); + +test('controlPanel Map section should include autozoom control', () => { + const mapSection = controlPanel.controlPanelSections.find( + ( + section: ControlPanelSectionConfig | null, + ): section is ControlPanelSectionConfig => + section !== null && section.label === 'Map', + ); + + // autozoom is imported from Shared_DeckGL and included in controlSetRows + expect(mapSection?.controlSetRows).toBeDefined(); + expect(mapSection?.controlSetRows.length).toBeGreaterThan(0); +}); Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Test logic mismatch</b></div> <div id="fix"> Similar to the viewport test, this only checks controlSetRows length >0 without verifying autozoom control presence, risking undetected removal. </div> </div> <small><i>Code Review Run #acb56e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
