bito-code-review[bot] commented on code in PR #37497:
URL: https://github.com/apache/superset/pull/37497#discussion_r2733612997
##########
superset-frontend/src/dashboard/actions/dashboardState.test.js:
##########
@@ -234,4 +236,61 @@ describe('dashboardState actions', () => {
);
});
});
+
+ // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from
describe blocks
+ describe('fetchFaveStar', () => {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing global test function definitions in
scope</b></div>
<div id="fix">
The new test code uses `describe`, `test`, and `expect` functions without
importing them. These are Jest globals that need to be available in the test
file. Add the necessary imports or ensure Jest globals are properly configured
in your test setup.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
@@ -24,6 +24,7 @@
SAVE_DASHBOARD_STARTED,
saveDashboardRequest,
SET_OVERRIDE_CONFIRM,
+ fetchFaveStar,
+ TOGGLE_FAVE_STAR,
} from 'src/dashboard/actions/dashboardState';
import { UPDATE_COMPONENTS_PARENTS_LIST } from
'src/dashboard/actions/dashboardLayout';
import {
@@ -1,3 +1,5 @@
+import { describe, test, expect } from '@jest/globals';
+
import {
SAVE_DASHBOARD_STARTED,
```
</div>
</details>
</div>
<small><i>Code Review Run #8471c0</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
