bito-code-review[bot] commented on code in PR #34629:
URL: https://github.com/apache/superset/pull/34629#discussion_r2733818580
##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -635,7 +635,7 @@ const DashboardBuilder = () => {
editMode={editMode}
// you cannot drop on/displace tabs if they already exist
disableDragDrop={!!topLevelTabs}
- style={draggableStyle}
+ css={draggableStyle}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect prop for styling</b></div>
<div id="fix">
It looks like this change from style to css might not apply the marginLeft
styling, since the Droppable component destructures a style prop and passes it
to the styled div, but doesn't handle a css prop. If the component wasn't
updated to accept css in this PR, the draggable area's positioning could be
affected.
</div>
</div>
<small><i>Code Review Run #3715fe</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
