Rishu1724 commented on code in PR #37484:
URL: https://github.com/apache/superset/pull/37484#discussion_r2734904340
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -243,7 +243,7 @@ function createAxisControl(axis: 'x' | 'y'):
ControlSetRow[] {
name: 'truncateYAxis',
config: {
type: 'CheckboxControl',
- label: t('Truncate Axis'),
+ label: t('Truncate Y Axis'),
Review Comment:
Yes, I agree — this should be dynamic based on the chart orientation. In
horizontal bar charts, the value axis is on X instead of Y, so showing a static
“Truncate Y Axis” control can be misleading.
I can update this to conditionally render based on vertical/horizontal mode
to better reflect the active value axis.
Also, thanks for the heads-up about the similar PR — I’ll check it and make
sure this change doesn’t duplicate existing work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
