wuqicyber commented on code in PR #37521:
URL: https://github.com/apache/superset/pull/37521#discussion_r2736494162
##########
superset/models/helpers.py:
##########
@@ -2800,6 +2800,21 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
col = self.convert_tbl_column_to_sqla_col(
columns_by_name[col], template_processor=template_processor
)
+ elif isinstance(col, str) and columns:
+ # Check if this is a label reference to an adhoc column
+ adhoc_col = next(
+ (
+ c
+ for c in columns
+ if utils.is_adhoc_column(c) and c.get("label") == col
+ ),
+ None,
+ )
+ if adhoc_col:
+ col = self.adhoc_column_to_sqla(
+ col=adhoc_col,
+ template_processor=template_processor,
+ )
Review Comment:
Adhoc columns are not aggregates - they're just SQL expressions for custom
columns. Setting need_groupby = True would incorrectly add GROUP BY to simple
queries without aggregates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
