Facyla commented on PR #37105: URL: https://github.com/apache/superset/pull/37105#issuecomment-3811849118
Hi @rusackas, Sorry for late reply, i have replied to bot suggestions - this gives interesting advices, but i am not sure all of them should be applied, and some of them were rather on changes that were already validated and integrated into main. I might fix them too (redundant positioning and inlined css into JS script instead of plain CSS) if it is a requisite for this PR, but would rather go for a minimalistic change for this particular PR which was intended to be a very specific and targeted fix. I am surprised by the package* conflicts, which were not touched for this PR. I'll solve them by keeping the "main" version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
