alex-poor commented on PR #37109: URL: https://github.com/apache/superset/pull/37109#issuecomment-3813775900
hey all - I need some guidance pls on intended behavior in this modal. As a user I want the entire dataset to be exported from the modal - right now modal is calling `getDatasourceSamples` which uses `SAMPLES_ROW_LIMIT`. It means that your drill down row count might be 1.6k rows, but you will only get max 1000 rows from the export. I feel like `SAMPLES_ROW_LIMIT` is designed for Explore view, but also there can be a large amount of data in this modal and probably it should be capped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
