bito-code-review[bot] commented on code in PR #37536:
URL: https://github.com/apache/superset/pull/37536#discussion_r2739279744
##########
docs/src/pages/community.tsx:
##########
@@ -188,39 +244,42 @@ const Community = () => {
subtitle="Get involved in our welcoming, fast growing community!"
/>
</BlurredSection>
- <StyledJoinCommunity>
- <List
- className="list"
- itemLayout="horizontal"
- dataSource={communityLinks}
- renderItem={({ url, title, description, image, ariaLabel }) => (
- <List.Item className="item">
- <List.Item.Meta
- avatar={
- <a
- className="title"
- href={url}
- target="_blank"
- rel="noreferrer"
- aria-label={ariaLabel}
- >
- <img className="icon" src={`/img/community/${image}`} />
- </a>
- }
- title={
- <a href={url} target="_blank" rel="noreferrer">
- <p className="title" style={{ marginBottom: 0 }}>
- {title}
- </p>
- </a>
- }
- description={<p className="description">{description}</p>}
- aria-label="Community link"
- />
- </List.Item>
- )}
- />
- </StyledJoinCommunity>
+ <section>
+ <StyledCardGrid>
+ {communityLinks.map(({ url, title, description, image }) => (
+ <a
+ key={title}
+ className="card"
+ href={url}
+ target="_blank"
+ rel="noreferrer"
+ >
+ <img className="icon" src={`/img/community/${image}`} alt="" />
+ <div className="card-body">
+ <div className="title">{title}</div>
+ <div className="description">{description}</div>
+ </div>
+ </a>
+ ))}
+ </StyledCardGrid>
+ </section>
+ <BlurredSection>
+ <SectionHeader level="h2" title="Follow Us" />
+ <StyledSocialGrid>
+ {socialLinks.map(({ url, title, image }) => (
+ <a
+ key={title}
+ className="card"
+ href={url}
+ target="_blank"
+ rel="noreferrer"
+ >
+ <img className="icon" src={`/img/community/${image}`} alt="" />
Review Comment:
<!-- Bito Reply -->
Yes, replacing empty alt attributes with alt={title} improves accessibility
by providing meaningful descriptions for screen readers, allowing them to
announce the link's purpose effectively.
**docs/src/pages/community.tsx**
```
<img className="icon" src={`/img/community/${image}`} alt={title} />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
