villebro commented on issue #29839: URL: https://github.com/apache/superset/issues/29839#issuecomment-3815515455
Thanks for the feedback @aminghadersohi ! Good callout on locking - we actually have the `DistributedLock` context manager that's perfect for this. Let me implement that to make sure we eliminate races. Regarding retries, I'm still on the fence about that. [`backoff`](https://pypi.org/project/backoff/) already has very rich retry semantics, and I the way things are looking it should be straight forward to wrap the tasks with backoff to achieve whichever backoff strategy you want. But we'll see. At any rate we'll tackle that when we get to migrating Alerts & Reports (if you look at the PR, you can see that it's trivial to add new functionality via `TaskProperties`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
