msyavuz commented on code in PR #37522:
URL: https://github.com/apache/superset/pull/37522#discussion_r2740758238
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -140,11 +140,17 @@ export default function transformProps(
currencyFormats = {},
columnFormats = {},
currencyCodeColumn,
- } = datasource;
+ } = datasource as typeof datasource & { currencyCodeColumn?: string };
+ const queryData0 = queriesData[0] as TimeseriesChartDataResponseResult & {
+ detected_currency?: string | null;
+ };
+ const queryData1 = queriesData[1] as TimeseriesChartDataResponseResult & {
+ detected_currency?: string | null;
+ };
const { label_map: labelMap, detected_currency: backendDetectedCurrency } =
- queriesData[0] as TimeseriesChartDataResponseResult;
+ queryData0;
const { label_map: labelMapB, detected_currency: backendDetectedCurrencyB } =
- queriesData[1] as TimeseriesChartDataResponseResult;
+ queryData1;
Review Comment:
This change doesn't seem necessary?
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -138,13 +139,16 @@ export default function transformProps(
columnFormats = {},
currencyFormats = {},
currencyCodeColumn,
- } = datasource;
+ } = datasource as typeof datasource & { currencyCodeColumn?: string };
const [queryData] = queriesData;
+ const queryDataTyped = queryData as TimeseriesChartDataResponseResult & {
+ detected_currency?: string | null;
+ };
const {
data = [],
label_map = {},
detected_currency: backendDetectedCurrency,
- } = queryData as TimeseriesChartDataResponseResult;
+ } = queryDataTyped;
Review Comment:
Same thing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
