VinayaKumar12 commented on code in PR #37517:
URL: https://github.com/apache/superset/pull/37517#discussion_r2742094616
##########
superset-frontend/src/explore/reducers/exploreReducer.js:
##########
@@ -124,7 +124,15 @@ export default function exploreReducer(state = {}, action)
{
},
[actions.SET_FIELD_VALUE]() {
const { controlName, value, validationErrors } = action;
- let new_form_data = { ...state.form_data, [controlName]: value };
+ // Normalize server_page_length to number if it's a non-empty string
representing an integer
+ const normalizedValue =
+ controlName === 'server_page_length' &&
+ typeof value === 'string' &&
+ value.trim() !== '' &&
+ Number.isInteger(Number(value))
+ ? Number(value)
Review Comment:
<img width="957" height="650" alt="image"
src="https://github.com/user-attachments/assets/87a960eb-0409-45a8-ba8a-9464df58fe82";
/>
UI validates the 99.5 , considers it as not an Integer and doesn't allow to
proceed further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
