sfirke commented on PR #37304:
URL: https://github.com/apache/superset/pull/37304#issuecomment-3819967673
@ionik0 pre-commit checks are still failing. It doesn't make sense for
someone to review it until those are sorted out. When I click the "pre-commit
checks / pre-commit (current) (pull_request)" failed test I see this in the logs
```
auto-walrus..............................................................Passed
mypy
(main)..............................................................Failed
- hook id: mypy
- exit code: 1
superset/utils/core.py:707: error: Unused "type: ignore" comment
[unused-ignore]
superset/utils/core.py:708: error: Unused "type: ignore" comment
[unused-ignore]
superset/utils/core.py:717: error: Unused "type: ignore" comment
[unused-ignore]
superset/mcp_service/screenshot/webdriver_pool.py:127: error: Unused "type:
ignore" comment [unused-ignore]
superset/mcp_service/screenshot/webdriver_pool.py:128: error: Unused "type:
ignore" comment [unused-ignore]
superset/mcp_service/screenshot/webdriver_pool.py:138: error: Unused "type:
ignore" comment [unused-ignore]
superset/mcp_service/screenshot/webdriver_pool.py:179: error: Unused "type:
ignore" comment [unused-ignore]
superset/mcp_service/screenshot/webdriver_pool.py:181: error: Unused "type:
ignore" comment [unused-ignore]
tests/unit_tests/sql/execution/test_executor.py:1296: error: Item "None" of
"str | None" has no attribute "lower" [union-attr]
tests/unit_tests/sql/execution/test_executor.py:1437: error: Unsupported
right operand type for in ("str | None") [operator]
tests/unit_tests/sql/execution/test_executor.py:1468: error: Unsupported
right operand type for in ("str | None") [operator]
tests/unit_tests/sql/execution/test_executor.py:1973: error: Unsupported
right operand type for in ("str | None") [operator]
tests/unit_tests/sql/execution/test_executor.py:2013: error: Unsupported
right operand type for in ("str | None") [operator]
Found 13 errors in 3 files (checked 1743 source files)
```
Your PR should not be touching those files as they are unrelated to this
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
