phmoraesrodrigues commented on PR #37461: URL: https://github.com/apache/superset/pull/37461#issuecomment-3823253931
> @semohr this approach ensures consistent behavior across Dashboard View as Table, Explore results, and Drill By modals, while avoiding code duplication and extra props. > > @phmoraesrodrigues, does this plan make sense to you once @semohr’s PR #37396 is merged? > > * Remove custom label extraction logic > * Use collabels from chartData directly > * Update tests accordingly > * Verify Drill By modal shows correct labels Yeah, completely agree! Gonna refactor this. Thanks all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
