SBIN2010 commented on PR #20588: URL: https://github.com/apache/superset/pull/20588#issuecomment-3825740808
Hi @comdiv ! Please let me know if you would like to continue. This PR is required for rebasing to master. And I would break the groupingValueSort function into smaller functions for better code readability and add tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
