rusackas commented on PR #37625: URL: https://github.com/apache/superset/pull/37625#issuecomment-3840073539
## Rebase Complete The PR has been rebased on latest master and all merge conflicts have been resolved. ### Regarding Automated Review Comments The automated review comments suggest improvements to the ESLint rule implementations (e.g., checking all arguments in translation calls instead of just the first). These are valid enhancement suggestions, but they represent pre-existing behavior from the original JavaScript code - not regressions from the TypeScript migration. This PR is focused on: 1. Converting JS/JSX files to TypeScript 2. Removing deprecated dependencies (prop-types, react-hot-loader, sinon) 3. Migrating from sinon to jest mocking 4. Updating documentation references The suggested ESLint rule improvements would be good follow-up work but are out of scope for this migration PR. ### Known Pre-existing Type Errors The type checker identifies some pre-existing issues in `DatasetList` test files and `DatasourceEditor.tsx` that exist on master. These are not regressions from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
