sadpandajoe commented on PR #37623: URL: https://github.com/apache/superset/pull/37623#issuecomment-3842648184
> > Subsequently, #36662 upgraded fetch-mock from v11.1.5 to v12.6.0, which introduced breaking API changes. > > @sadpandajoe @rusackas Do you know why CI didn't fail previously? @michael-s-molina, @hainenber is correct that there were no tests that used the same `fetch-mock` calls that I had in https://github.com/apache/superset/pull/36681 as those calls were deprecated. The PR was working and since I didn't touch the original files, there were no conflicts. Pair that with the GHA outage post-merge, it was hard to have caught it right away. So I actually caught it a lot later when I noticed another branch I was working on failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
