rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2760242094
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx:
##########
@@ -351,7 +351,7 @@ const ColumnSelectPopover = ({
tab => {
getCurrentTab(tab);
setSelectedTab(tab);
- // @ts-ignore
+ // @ts-expect-error - AceEditor ref type doesn't expose editor.focus()
sqlEditorRef.current?.editor.focus();
Review Comment:
Fixed in 896b19737d. Updated to use `.focus()` directly and properly typed
the ref as `useRef<editors.EditorHandle>(null)`. The @ts-expect-error has been
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
