kgabryje commented on code in PR #37649:
URL: https://github.com/apache/superset/pull/37649#discussion_r2762485254
##########
superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx:
##########
@@ -90,11 +90,16 @@ const ModalFooter = ({ formData, closeModal }:
ModalFooterProps) => {
findPermission('can_explore', 'Superset', state.user?.roles),
);
- const [datasource_id, datasource_type] = formData.datasource.split('__');
+ const [datasourceIdStr, datasource_type] = formData.datasource.split('__');
+ // Try to parse as integer, fall back to string (UUID) if NaN
+ const parsedDatasourceId = parseInt(datasourceIdStr, 10);
Review Comment:
And actually, since the id can be a string now, do we need to parse
stringified numbers into integers? Cant we just leave them as strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
