bito-code-review[bot] commented on code in PR #37677: URL: https://github.com/apache/superset/pull/37677#discussion_r2765149744
########## docs/versioned_docs/version-6.0.0/configuration/databases.mdx: ########## @@ -861,6 +862,59 @@ To be able to upload CSV or Excel files to BigQuery in Superset, you'll need to Currently, the Google BigQuery Python SDK is not compatible with `gevent`, due to some dynamic monkeypatching on python core library by `gevent`. So, when you deploy Superset with `gunicorn` server, you have to use worker type except `gevent`. +#### Google Datastore + +The recommended connector library for Google Datastore is +[python-datastore-sqlalchemy](https://github.com/splasky/Python-datastore-sqlalchemy). + +##### Install Datastore Driver + +Follow the steps [here](/docs/configuration/databases#installing-drivers-in-docker-images) about how to +install new database drivers when setting up Superset locally via docker compose. + +```bash +echo "python-datastore-sqlalchemy" >> ./docker/requirements-local.txt +``` + +##### Connecting to Datastore + +When adding a new Datastore connection in Superset, you'll need to add the GCP Service Account +credentials file (as a JSON). + +1. Create your Service Account via the Google Cloud Platform control panel, provide it access to the + appropriate Datastore datasets, and download the JSON configuration file for the service account. +2. In Superset, you can either upload that JSON or add the JSON blob in the following format (this should be the content of your credential JSON file): + +```json +{ + "type": "service_account", + "project_id": "...", + "private_key_id": "...", + "private_key": "...", + "client_email": "...", + "client_id": "...", + "auth_uri": "...", + "token_uri": "..." +} Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete JSON Example</b></div> <div id="fix"> The JSON example for the service account credentials appears incomplete compared to standard GCP service account JSON files, which include additional fields like 'auth_provider_x509_cert_url' and 'client_x509_cert_url'. This could confuse users trying to copy the example directly. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion "auth_uri": "...", "token_uri": "...", "auth_provider_x509_cert_url": "...", "client_x509_cert_url": "..." } ```` </div> </details> </div> <small><i>Code Review Run #d5185b</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
