rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2765505479
##########
superset-frontend/plugins/legacy-plugin-chart-horizon/src/HorizonChart.tsx:
##########
@@ -113,7 +118,7 @@ class HorizonChart extends PureComponent {
>
{data.map(row => (
<HorizonRow
- key={row.key}
+ key={row.key as unknown as string}
Review Comment:
Good catch! The double cast was a workaround because row.key is typed as
string[] while React's key expects string | number.
I've updated it to use row.key.join(',') which explicitly converts the array
to a string, matching the pattern already used for title on the next line. This
is cleaner and more explicit about the intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
