bito-code-review[bot] commented on PR #37358:
URL: https://github.com/apache/superset/pull/37358#issuecomment-3850116108
<!-- Bito Reply -->
Yes, using `key={formValuesVersion}` on StyledCollapse will cause the entire
component tree to unmount and remount on every form change, including
keystrokes, due to the incrementing version. This is performance-heavy as it
destroys and recreates DOM elements unnecessarily. If the goal is to reset
collapse state on form changes, consider alternatives like updating `activeKey`
directly or using internal component state instead of the key prop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
