bito-code-review[bot] commented on code in PR #37680: URL: https://github.com/apache/superset/pull/37680#discussion_r2766354028
########## superset/migrations/versions/2026-02-04_16-32_91b151e8dac1_add_onboarding_workflows.py: ########## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Add onboarding workflows tables + +Revision ID: 91b151e8dac1 +Revises: 9787190b3d89 +Create Date: 2026-02-04 16:32:25.570254 + +""" + +# revision identifiers, used by Alembic. +revision = '91b151e8dac1' +down_revision = '9787190b3d89' + +from alembic import op Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Module imports not at top of file</b></div> <div id="fix"> Imports on lines 29-30 must be placed before the module docstring and revision identifiers. Move `from alembic import op` and `import sqlalchemy as sa` to the top of the file after the license header. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` # under the License. +from alembic import op +import sqlalchemy as sa """Add onboarding workflows tables Revision ID: 91b151e8dac1 @@ -26,8 +28,6 @@ revision = '91b151e8dac1' down_revision = '9787190b3d89' -from alembic import op -import sqlalchemy as sa def upgrade(): ``` </div> </details> </div> <small><i>Code Review Run #82c1c7</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
