aminghadersohi commented on PR #36368:
URL: https://github.com/apache/superset/pull/36368#issuecomment-3850940647
Hey Ville, the concurrency and performance tables in the description are
great - makes it really easy to reason about the DB overhead per operation.
Clean work on the atomic SQL vs distributed lock split too.
Couple things I was wondering about:
Sync join-and-wait - the whole pitch of GTF is getting long-running work off
web workers, but when a sync caller hits a deduplicated task, join-and-wait
blocks the web worker polling until the async task completes doing zero useful
work. What's the scenario where that's the right call vs just forcing callers
to .schedule() and returning a task UUID?
Also noticed the @task decorator checks
is_feature_enabled("GLOBAL_TASK_FRAMEWORK") at import time, not at
call/schedule time. So if any module with @task-decorated functions gets
imported during app startup or Celery autodiscovery with the flag off, the app
just crashes. That kind of kills the coexistence rollout strategy - deferring
the check to __call__/.schedule() would fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
