Copilot commented on code in PR #37542:
URL: https://github.com/apache/superset/pull/37542#discussion_r2767215301
##########
docs/package.json:
##########
@@ -81,7 +81,7 @@
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-github-btn": "^1.4.0",
- "react-resize-detector": "7.1.2",
+ "react-resize-detector": "12.3.0",
Review Comment:
This dependency update introduces breaking changes that are incompatible
with the current codebase. The react-resize-detector library was upgraded from
v7.1.2 to v12.3.0, but according to the release notes, v11.0.0 changed the
onResize callback API from accepting separate (width, height) parameters to a
single object with destructured properties.
The superset-frontend code (which is used at runtime in the docs build per
webpack.extend.ts comments) still uses the old API in multiple files:
-
superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBar.tsx
line 196-208
-
superset-frontend/packages/superset-ui-core/src/components/Table/VirtualTable.tsx
line 87
These files need to be updated to use the new API signature: onResize: ({
width, height }) => { ... } instead of onResize: (width) => { ... }
Additionally, superset-frontend/package.json and
superset-frontend/packages/superset-ui-core/package.json still specify
react-resize-detector ^7.1.2, creating a version mismatch.
```suggestion
"react-resize-detector": "^7.1.2",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
