codeant-ai-for-open-source[bot] commented on PR #37699:
URL: https://github.com/apache/superset/pull/37699#issuecomment-3853348259
## **Sequence Diagram**
The PR fixes SQL autocomplete by passing full keyword objects (with metadata
like docHTML/score/meta) from popovers into SQLEditorWithValidation instead of
mapping them to plain strings. This ensures the editor's rich autocomplete
works for custom dimensions and filters; a test verifies the props passed to
the editor contain the expected object fields.
```mermaid
sequenceDiagram
participant ColumnPopover as ColumnSelectPopover
participant FilterPopover as AdhocFilterEditPopoverSqlTabContent
participant SQLEditor as SQLEditorWithValidation
participant Ace as AceAutocomplete
participant Test as ComponentTest
ColumnPopover->>SQLEditor: Render with keywords (full objects)
FilterPopover->>SQLEditor: Render with keywords (full objects)
SQLEditor->>Ace: Provide keywords (objects with docHTML/score/meta)
Ace-->>SQLEditor: Use metadata for rich autocomplete suggestions
Test->>SQLEditor: Mock & assert received keywords include
docHTML/score/meta
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
