michael-s-molina opened a new pull request, #37704: URL: https://github.com/apache/superset/pull/37704
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Validated and corrected the extensions documentation in `docs/developer_portal/extensions/` against the actual codebase implementation. #### Changes ##### `docs/developer_portal/extensions/development.md` **Fixed incorrect API signatures and types:** - Changed `onDidQueryRun` and `onDidQueryStop` event types from `Event<Editor>` to `Event<QueryContext>` to match the actual implementation in `superset-frontend/packages/superset-core/src/api/sqlLab.ts` - Fixed `commands.registerCommand` example to use callback function syntax instead of object syntax: ```typescript // Before (incorrect) commands.registerCommand('id', { title: 'Title', execute: () => {} }); // After (correct) commands.registerCommand('id', () => {}); ``` - Updated event handler example to use correct parameter name (`queryContext` instead of `editor`) ##### `docs/developer_portal/extensions/extension-points/sqllab.md` **Updated to reflect actual implementation:** - Reduced extension points from 5 to 4 (removed Status Bar - not yet supported) - Updated layout diagram to remove Status Bar - Added Views/Menus support columns to clarify what each area supports: | Extension Point | Views | Menus | |-----------------|-------|-------| | Left Sidebar | — | ✓ | | Editor | ✓* | ✓ | | Right Sidebar | ✓ | — | | Panels | ✓ | ✓ | - Added footnote explaining Editor views use Editor Contributions - Reorganized into clearer "Customization Types" sections (Views, Menus, Custom Editors) - Removed Context Actions (not implemented in `PanelToolbar`) - Updated toolbar diagram to show buttons on the left - Fixed `commands.registerCommand` examples to use correct callback syntax ### TESTING INSTRUCTIONS Check the new docs. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
