rusackas commented on PR #34565: URL: https://github.com/apache/superset/pull/34565#issuecomment-3857811697
## Addressed Review Feedback Rebased on latest master and fixed the pre-commit/mypy failures: **Fixed: MagicMock `__str__` issue (CodeAnt-AI)** The test was using `mock_locale.__str__ = lambda self: "de_DE"` which doesn't work because Python's `str()` function uses the type-level `__str__` method, not instance attributes. Fixed by using a simple `MockLocale` class with a proper `__str__` method. **Regarding Bito suggestion on `pytest.mark.parametrize`:** The comma-separated string format (`"locale_str,expected_language"`) is valid pytest syntax and commonly used. Both string and tuple formats are acceptable, so I've kept the current format. All pre-commit checks now pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
