bito-code-review[bot] commented on code in PR #37747:
URL: https://github.com/apache/superset/pull/37747#discussion_r2772904946
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -718,7 +718,7 @@ export class TableRenderer extends Component {
true,
)}
>
- {t('Subtotal')}
+ {t('Subvalue')}
</th>,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect pivot table label</b></div>
<div id="fix">
The change from 'Subtotal' to 'Subvalue' appears incorrect, as 'Subvalue' is
not a standard term in pivot tables and doesn't align with the
'pvtSubtotalLabel' className. Pivot tables use 'Subtotal' for aggregated
subgroup values, and this change could confuse users. Reverting to 'Subtotal'
matches existing codebase usage and translations.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
>
{t('Subtotal')}
</th>,
````
</div>
</details>
</div>
<small><i>Code Review Run #0a4592</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -931,7 +931,7 @@ export class TableRenderer extends Component {
true,
)}
>
- {t('Subtotal')}
+ {t('Subvalue')}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect pivot table label</b></div>
<div id="fix">
Similar to the other location, changing 'Subtotal' to 'Subvalue' is
incorrect for pivot table terminology. 'Subvalue' isn't standard and mismatches
the 'pvtSubtotalLabel' className. Revert to 'Subtotal' for consistency with
pivot table conventions and existing code.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
{t('Subtotal')}
````
</div>
</details>
</div>
<small><i>Code Review Run #0a4592</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
